gh-138774: use value to ast.unparse code when str is None in ast.Interpolation#139415
Merged
JelleZijlstra merged 11 commits intopython:mainfrom Oct 23, 2025
Merged
gh-138774: use value to ast.unparse code when str is None in ast.Interpolation#139415JelleZijlstra merged 11 commits intopython:mainfrom
value to ast.unparse code when str is None in ast.Interpolation#139415JelleZijlstra merged 11 commits intopython:mainfrom
Conversation
George-Ogden
requested review from
Eclips4,
JelleZijlstra,
isidentical and
tomasr8
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
JelleZijlstra
approved these changes
Oct 20, 2025
Member
|
This looks good but we do need a NEWS entry. Also, perhaps @davepeck can take a look since this is about t-strings? |
Contributor
|
👍 LGTM, thanks! |
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
You still need to add a NEWS entry.
Also, please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.
|
Thanks @George-Ogden for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2025
…e` in `ast.Interpolation` (pythonGH-139415) (cherry picked from commit 4d08494) Co-authored-by: George Ogden <38294960+George-Ogden@users.noreply.github.com>
|
GH-140503 is a backport of this pull request to the 3.14 branch. |
|
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…e` in `ast.Interpolation` (python#139415)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--139415.org.readthedocs.build/